Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

Dawit Alemayehu adawit at kde.org
Mon Nov 8 17:12:54 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5795/
-----------------------------------------------------------

(Updated 2010-11-08 17:12:54.269260)


Review request for kdelibs.


Changes
-------

Surrounded literal text with QLatin1String...


Summary
-------

The attached patch makes it possible to compile kdelibs using the global Qt defines that improve the performance of QString concatenation, i.e. QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR. For more details about faster QString concatenation, see "More Efficient String Construction" section of QString's documentation.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp 1194086 
  trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1194086 
  trunk/KDE/kdelibs/kdewebkit/kwebpluginfactory.cpp 1194086 
  trunk/KDE/kdelibs/khtml/ecma/kjs_scriptable.cpp 1194086 
  trunk/KDE/kdelibs/khtml/ecma/kjs_scriptable.cpp 1194086 
  trunk/KDE/kdelibs/knewstuff/knewstuff3/core/cache.cpp 1194086 
  trunk/KDE/kdelibs/plasma/datacontainer.cpp 1194086 
  trunk/KDE/kdelibs/plasma/widgets/declarativewidget.cpp 1194086 

Diff: http://svn.reviewboard.kde.org/r/5795/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101108/d212ddd5/attachment.htm>


More information about the kde-core-devel mailing list