Review Request: Few minor improvments for UDisks solid backend manager...

Dawit Alemayehu adawit at
Mon Nov 8 07:11:53 GMT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


The attached patch does the following:

1.) Remove the call to allDevices() from UDisksManager's ctor. Instead a new
private method is added to properly initialize the devices list cache before

2.) Remove the 'result' variable from UDisksManager::allDevices since it is
unnecessary and m_deviceCache can be used directly.

3.) Other minor namespace (foreach -> Q_FOREACH) and macro-performance (moving
the call for propertyCount() out of the for loop.

Note that the Bug number above is only mentioned as a reference to point out the origins of the attached patches...

This addresses bug 253039.


  trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksdevice.cpp 1192709 
  trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.h 1192709 
  trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp 1192709 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list