Review Request: use QPropertyAnimation instead of QTimeLine to animated clear button in KLineEdit

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3808/#review5616
-----------------------------------------------------------

Ship it!


a couple of minor issues noted below, but generally looks fine :)


/trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h
<http://reviewboard.kde.org/r/3808/#comment5313>

    can probably drop this line wince it gets set each time anyways in animateVisible(bool)?



/trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h
<http://reviewboard.kde.org/r/3808/#comment5312>

    if you call update() in setOpacity, you don't need to connect to this signal.
    
    in fact, if in setOpacity() you do a check for m_opacity == 0 and hide on that, you shouldn't need to connect to the finished() signal either.



/trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h
<http://reviewboard.kde.org/r/3808/#comment5314>

    this comment should probably be updated to not reference m_timeline :)



/trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h
<http://reviewboard.kde.org/r/3808/#comment5310>

    no reason for it to be virtual



/trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h
<http://reviewboard.kde.org/r/3808/#comment5311>

    no reason for it to be virtual


- Aaron


On 2010-04-25 22:19:17, Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3808/
> -----------------------------------------------------------
> 
> (Updated 2010-04-25 22:19:17)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As discussed with Aaron, changed QTimeLine into QPropertyAnimation. This should provide smoother and more efficient fade-in/fade-out effect.
> 
> This is the first of two patches.
> The second will use different pixmaps on mouse hover, but might also require change to klineedit.cpp
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h 1118793 
> 
> Diff: http://reviewboard.kde.org/r/3808/diff
> 
> 
> Testing
> -------
> 
> Same as before: dolphin/konqueror
> 
> 
> Thanks,
> 
> Hugo
> 
>