Review Request: use QPropertyAnimation instead of QTimeLine to animated clear button in KLineEdit
Hugo Pereira Da Costa
hugo at oxygen-icons.org
Wed May 12 02:50:55 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3808/#review5615
-----------------------------------------------------------
Anyone interested in this ?
I know the description promises another patch that provides hover effect on the clear button, but so far I have had no time to work on it.
Since this patch presumably make the fade-in fade-out animation smoother, I think it's worth being reviewed stand-alone nonetheless.
Hugo
- Hugo
On 2010-04-25 22:19:17, Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3808/
> -----------------------------------------------------------
>
> (Updated 2010-04-25 22:19:17)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> As discussed with Aaron, changed QTimeLine into QPropertyAnimation. This should provide smoother and more efficient fade-in/fade-out effect.
>
> This is the first of two patches.
> The second will use different pixmaps on mouse hover, but might also require change to klineedit.cpp
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h 1118793
>
> Diff: http://reviewboard.kde.org/r/3808/diff
>
>
> Testing
> -------
>
> Same as before: dolphin/konqueror
>
>
> Thanks,
>
> Hugo
>
>
More information about the kde-core-devel
mailing list