Review Request: use QPropertyAnimation instead of QTimeLine to animated clear button in KLineEdit

Hugo Pereira Da Costa hugo at oxygen-icons.org
Wed May 12 15:54:26 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3808/
-----------------------------------------------------------

(Updated 2010-05-12 14:54:26.063253)


Review request for kdelibs.


Changes
-------

Updated to account for Aaron's suggestions (thanks for the tip on signal/slot connections, I might use it elsewhere in oxygen); and committed 


Summary
-------

As discussed with Aaron, changed QTimeLine into QPropertyAnimation. This should provide smoother and more efficient fade-in/fade-out effect.

This is the first of two patches.
The second will use different pixmaps on mouse hover, but might also require change to klineedit.cpp


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h 1125861 

Diff: http://reviewboard.kde.org/r/3808/diff


Testing
-------

Same as before: dolphin/konqueror


Thanks,

Hugo





More information about the kde-core-devel mailing list