New dependency for kdelibs and kdebase: dbusmenu-qt

[Alexander Neundorf]

On Thursday 29 April 2010, Andreas Pakulat wrote:
> On 29.04.10 08:17:03, Aaron J. Seigo wrote:
> > On April 28, 2010, Andreas Pakulat wrote:
> > > I know, I recall seeing a review-request. But there was no sign that
> > > this is going live and when this is going live _before_ the commit. The
> >
> > that's the entire POINT of a review request and why they get forwarded to
> > important mailing lists like this. if you want to provide feedback, then
> > provide feedback then.
>
> My main problem with this was that it wasn't announced before and no a
> review-request is not enough. There should be a warning send to all major
> lists (in particular kde-devel and eventually the kde-cvs-announce list)
> before adding a new dependency and with a concrete date when this new
> dependency is added. A review request is not the right tool for doing that,
> its the right tool to discuss what the code using the new dep will look
> like.

I agree completely.
I don't feel like digging through all review requests like "Add something for 
Foo" to check whether this maybe also installs new cmake files, if I am not 
involved in project Foo otherwise.

> > > And the review-request wasn't posted to the buildsystem list at all,
> > > which is a requirement before introducing new, especially installed,
> > > cmake files.
> >
> > yes, apparently it is according to this:
> >
> > 	http://techbase.kde.org/Policies/CMake_Commit_Policy
> >
> > in future i'll try and ensure that happens when its something that
> > touches my code or code i work with.
>
> I'd like to note that this is not new and has been posted to all major
> lists when it went into effect sometime last year (IIRC).

Yes.

Alex