Review Request: Convert the KEditListBox into a KEditListWidget

Sebastian Trueg trueg at kde.org
Tue Jun 29 15:20:50 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4495/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Currently KEditListBox is derived from QGroupBox which makes it a bit inflexible. This patch introduces the new class KEditListWidget which is essentially the same but derived from QWidget. That way one can add additional widgets in a surrounding group box which is exactly what I do in the Nepomuk configuration dialog.
I did not change the KEditListBox implementation to use KEditListWidget internally since the former does expose some protected methods and I did not want to spend a whole lot of time on that and then having this request rejected.


Diffs
-----

  trunk/KDE/kdelibs/includes/CMakeLists.txt 1142170 
  trunk/KDE/kdelibs/includes/KEditListWidget PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1142170 
  trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h 1142170 
  trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kdewidgets/kde.widgets 1142170 
  trunk/KDE/kdelibs/kdewidgets/kdewidgets.qrc 1142170 
  trunk/KDE/kdelibs/kdewidgets/pics/keditlistwidget.png UNKNOWN 

Diff: http://reviewboard.kde.org/r/4495/diff


Testing
-------


Thanks,

Sebastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100629/fd052480/attachment.htm>


More information about the kde-core-devel mailing list