<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4495/">http://reviewboard.kde.org/r/4495/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Sebastian Trueg.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Currently KEditListBox is derived from QGroupBox which makes it a bit inflexible. This patch introduces the new class KEditListWidget which is essentially the same but derived from QWidget. That way one can add additional widgets in a surrounding group box which is exactly what I do in the Nepomuk configuration dialog.
I did not change the KEditListBox implementation to use KEditListWidget internally since the former does expose some protected methods and I did not want to spend a whole lot of time on that and then having this request rejected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/includes/CMakeLists.txt <span style="color: grey">(1142170)</span></li>
<li>trunk/KDE/kdelibs/includes/KEditListWidget <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/kdeui/CMakeLists.txt <span style="color: grey">(1142170)</span></li>
<li>trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h <span style="color: grey">(1142170)</span></li>
<li>trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/kdewidgets/kde.widgets <span style="color: grey">(1142170)</span></li>
<li>trunk/KDE/kdelibs/kdewidgets/kdewidgets.qrc <span style="color: grey">(1142170)</span></li>
<li>trunk/KDE/kdelibs/kdewidgets/pics/keditlistwidget.png <span style="color: grey">(UNKNOWN)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>