Review Request: Ensure notifications sent to DBus notification daemons are compatible with that daemon's capabilities

[Sjors Gielen]

Op 25 jul 2010, om 18:04 heeft Olivier Goffart het volgende geschreven:

> Le Sunday 25 July 2010, Sjors Gielen a écrit :
>>> On 2010-07-10 12:10:20, Olivier Goffart wrote:
>>>> This is better.
>>>> What i would have done is copy the text and title into local variable
>>>> and checked the capability in the sendNotificationDBus function. (and
>>>> do the same with actions)
>>> 
>>> Sjors Gielen wrote:
>>>    True, but I like the splitting of code like this. It's more elegant
>>>    imo ;-) Do you want me to change it once again, or can kde-core take
>>>    a peek? :)
>> 
>> How do I get kde-core to take a look and approve or reject? I can commit it
>> myself, but I guess I need their permission.
> 
> 
> You can commit yourself.
> Patch is good.

Committed, but annoyingly, I cancelled the commit to check one line again, but then svn suddenly committed with an incomplete log message. The first line of the log message should have been something like "Ensure notifications sent to DBus notification daemons are compatible with that daemon's capabilities" :-(

Oh well, the patch is in! On to implementing Growl support.

Thanks,
Sjors
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2214 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100725/16eda5ef/attachment.bin>