Review Request: Ensure notifications sent to DBus notification daemons are compatible with that daemon's capabilities

[Olivier Goffart]

Le Sunday 25 July 2010, Sjors Gielen a écrit :
> > On 2010-07-10 12:10:20, Olivier Goffart wrote:
> > > This is better.
> > > What i would have done is copy the text and title into local variable
> > > and checked the capability in the sendNotificationDBus function. (and
> > > do the same with actions)
> > 
> > Sjors Gielen wrote:
> >     True, but I like the splitting of code like this. It's more elegant
> >     imo ;-) Do you want me to change it once again, or can kde-core take
> >     a peek? :)
> 
> How do I get kde-core to take a look and approve or reject? I can commit it
> myself, but I guess I need their permission.


You can commit yourself.
Patch is good.