Moving the proxy model test suite to kdesupport?

[Andreas Pakulat]

On 15.07.10 18:31:20, Stephen Kelly wrote:
> Andreas Pakulat wrote:
> > On 15.07.10 17:14:30, Stephen Kelly wrote:
> >> Andreas Pakulat wrote:
> >> >> install the proxymodeltestsuite library if it is built (it is only
> >> >> built if KDE4_BUILD_TESTS is true).
> >> >> install the headers to ${INSTALL_LOCATION}/private
> >> >> not keep BC in the library.
> >> >> not make the library part of ${KDE4_KDEUI_LIBRARIES}
> >> >> not have the library packaged
> >> >> not have any applications link to it or use it
> >> > 
> >> > This won't work, the tests are packaged when kdelibs tarballs are
> >> > built, hence they need to be buildable from those packages too. That in
> >> > turn means that either all dependencies the tests need are inside
> >> > kdelibs or they are available from somewhere to download and install.
> >> 
> >> The tests are currently inside kdelibs. I don't intend to change that.
> >> 
> >> I only intend to add install() lines so that application developers can
> >> use the library to debug their applications.
> > 
> > If you install something as part of kdelibs you're bound by the kdelibs
> > rules wrt. bc etc. AFAIK.
> 
> Maybe it's time for us to decide if we should have exceptions to that if 
> it's only build when building unit tests, not useful to link to and has 
> headers installed to .../private/... ?

Yeap, maybe it is, but that'll need more input from other developers and
possibly it would be better to raise this in a separate thread?

> It's just not easy enough for people to use with me sitting next to them. 
> It's not a case of bragging.

Ok.

> So apart from policy, are there other technical reasons preventing the 
> installation of this stuff?

If you install library+headers it would be nice to also define a cmake
variable that people can use. This should be easy enough by producing a
cmake KDE4ProxyModelTestConfig.cmake file that sets up an import target
pointing to the library and the include-dir. Makes it a lot easier for
people using the library, they don't have to write lots of cmake code to
find the headers and library.

Other than that I can't see any technical problems.

Andreas

-- 
Life is to you a dashing and bold adventure.