Review Request: fixed file kioslave on windows (it was reporting non-existing files as existing)

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3938/#review6526
-----------------------------------------------------------


Good thing that you reminded me of this review request, David. When it was posted there was a mail in k-c-d warning about unicode handling in createUDSEntry() <http://lists.kde.org/?l=kde-games-devel&m=127343711202567&w=2> which I think I understand now (although I didn't back then). KDE_lstat should be KDE::lstat (which takes a QString instead of const char*) and possibly there should be a KDE::readlink that takes QString as well. Otherwise it might cause problems with unicode filenames. I think those issues should be addressed before commiting this patch.

- George


On 2010-05-10 18:38:48, Ilie Halip wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3938/
> -----------------------------------------------------------
> 
> (Updated 2010-05-10 18:38:48)
> 
> 
> Review request for kdelibs, George Kiagiadakis and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> This patch fixes the problem reported here: https://bugs.kde.org/show_bug.cgi?id=207162
> 
> It was a problem that I think happened all over KDE on Windows, because the kio_file slave was reporting incorrect information (S_IFREG for non-existing files). I removed the createUDSEntryWin function, and moved FileProtocol::stat inside file.cpp, because both unix and win now have a common implementation.
> 
> 
> This addresses bug 207162.
>     https://bugs.kde.org/show_bug.cgi?id=207162
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kioslave/file/file.cpp 1124299 
>   trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1124299 
>   trunk/KDE/kdelibs/kioslave/file/file_win.cpp 1124299 
> 
> Diff: http://reviewboard.kde.org/r/3938/diff
> 
> 
> Testing
> -------
> 
> listing files in directories
> saving/loading files from ktuberling with/without extension
> 
> 
> Thanks,
> 
> Ilie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100713/e02e0baa/attachment.htm>