Review Request: KIO : Remote preview

Iamluc luc at vieillescazes.net
Wed Jul 14 15:30:12 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4627/
-----------------------------------------------------------

Review request for kdelibs and Peter Penz.


Summary
-------

Hi,

There is a size limit for remote previews in Dolphin. By default, the limit is set to 0, so there is no preview for remote files.
But a ThumbCreator plugin can ignore this limit by setting "IgnoreMaximumSize=true" in the protocol .desktop file (like the ffmpegthumbnails creator).

This patch forces to ignore this property when using a remote protocol.

Luc.


Diffs
-----

  /trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1149793 

Diff: http://reviewboard.kde.org/r/4627/diff


Testing
-------

Tested with SFTP and FTP kio slaves. Files are not downloaded anymore. 


Thanks,

Iamluc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100714/23b0b333/attachment.htm>


More information about the kde-core-devel mailing list