<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/3938/">http://reviewboard.kde.org/r/3938/</a>
</td>
</tr>
</table>
<br />
<pre>Good thing that you reminded me of this review request, David. When it was posted there was a mail in k-c-d warning about unicode handling in createUDSEntry() <http://lists.kde.org/?l=kde-games-devel&m=127343711202567&w=2> which I think I understand now (although I didn't back then). KDE_lstat should be KDE::lstat (which takes a QString instead of const char*) and possibly there should be a KDE::readlink that takes QString as well. Otherwise it might cause problems with unicode filenames. I think those issues should be addressed before commiting this patch.</pre>
<br />
<p>- George</p>
<br />
<p>On May 10th, 2010, 6:38 p.m., Ilie Halip wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, George Kiagiadakis and Patrick Spendrin.</div>
<div>By Ilie Halip.</div>
<p style="color: grey;"><i>Updated 2010-05-10 18:38:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch fixes the problem reported here: https://bugs.kde.org/show_bug.cgi?id=207162
It was a problem that I think happened all over KDE on Windows, because the kio_file slave was reporting incorrect information (S_IFREG for non-existing files). I removed the createUDSEntryWin function, and moved FileProtocol::stat inside file.cpp, because both unix and win now have a common implementation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">listing files in directories
saving/loading files from ktuberling with/without extension</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=207162">207162</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kioslave/file/file.cpp <span style="color: grey">(1124299)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/file_unix.cpp <span style="color: grey">(1124299)</span></li>
<li>trunk/KDE/kdelibs/kioslave/file/file_win.cpp <span style="color: grey">(1124299)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/3938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>