Review Request: Change in KFileItemDelegate's renaming / editor behavior for directories

[Christian Muehlhaeuser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4513/
-----------------------------------------------------------

(Updated 2010-07-10 08:33:51.532181)


Review request for kdelibs and Fredrik Höglund.


Changes
-------

Update the diff to not only fix the inline renaming, but also KIO's RenameDialog.

Please re-review. Thanks!


Summary
-------

As discussed with FredrikH:

When renaming an item, KFileItemDelegate excludes the extension from the initial text selection.
While this makes perfect sense for files, directories don't typically have an extension, which indicates a filetype. They're directories after all.

This patch keeps the existing behavior for files, but always selects the entire text for directories.

Note, that I'm afraid I couldn't test the patch compiling nicely on 4.5 yet.
Since it's "just a two-liner (tm)", I'm confident it works fine as attached here and I'd hope someone on here could confirm it compiling / working for me, please?

Please don't commit the patch just yet. For consistency's sake I'm also fixing the behavior inside Dolphin's own RenameDialog right now. I'm going to commit
both patches at the same time, then.

Thanks in advance,
Chris


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1148207 
  trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1148207 

Diff: http://reviewboard.kde.org/r/4513/diff


Testing
-------


Thanks,

Christian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100710/1cde31af/attachment.htm>