Review Request: Change in KFileItemDelegate's renaming / editor behavior for directories

[Christian Muehlhaeuser]

> On 2010-07-03 20:14:32, Todd wrote:
> > This probaly also needs to be fixed in kdelibs renamedialog, which also excludes the extension from selections..

I will take a look at that, too, then. Thank you!


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4513/#review6353
-----------------------------------------------------------


On 2010-07-03 04:26:27, Christian Muehlhaeuser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4513/
> -----------------------------------------------------------
> 
> (Updated 2010-07-03 04:26:27)
> 
> 
> Review request for kdelibs and Fredrik Höglund.
> 
> 
> Summary
> -------
> 
> As discussed with FredrikH:
> 
> When renaming an item, KFileItemDelegate excludes the extension from the initial text selection.
> While this makes perfect sense for files, directories don't typically have an extension, which indicates a filetype. They're directories after all.
> 
> This patch keeps the existing behavior for files, but always selects the entire text for directories.
> 
> Note, that I'm afraid I couldn't test the patch compiling nicely on 4.5 yet.
> Since it's "just a two-liner (tm)", I'm confident it works fine as attached here and I'd hope someone on here could confirm it compiling / working for me, please?
> 
> Please don't commit the patch just yet. For consistency's sake I'm also fixing the behavior inside Dolphin's own RenameDialog right now. I'm going to commit
> both patches at the same time, then.
> 
> Thanks in advance,
> Chris
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1145462 
> 
> Diff: http://reviewboard.kde.org/r/4513/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100706/a809f036/attachment.htm>