<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4513/">http://reviewboard.kde.org/r/4513/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Fredrik Höglund.</div>
<div>By Christian Muehlhaeuser.</div>
<p style="color: grey;"><i>Updated 2010-07-10 08:33:51.532181</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Update the diff to not only fix the inline renaming, but also KIO's RenameDialog.
Please re-review. Thanks!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">As discussed with FredrikH:
When renaming an item, KFileItemDelegate excludes the extension from the initial text selection.
While this makes perfect sense for files, directories don't typically have an extension, which indicates a filetype. They're directories after all.
This patch keeps the existing behavior for files, but always selects the entire text for directories.
Note, that I'm afraid I couldn't test the patch compiling nicely on 4.5 yet.
Since it's "just a two-liner (tm)", I'm confident it works fine as attached here and I'd hope someone on here could confirm it compiling / working for me, please?
Please don't commit the patch just yet. For consistency's sake I'm also fixing the behavior inside Dolphin's own RenameDialog right now. I'm going to commit
both patches at the same time, then.
Thanks in advance,
Chris</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp <span style="color: grey">(1148207)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/renamedialog.cpp <span style="color: grey">(1148207)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4513/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>