Review Request: Unquoted/unescaped directory name passed to "cd" command in dolphin embedded terminal

David Faure faure at
Tue Jan 26 15:50:53 GMT 2010

On Monday 25 January 2010, Johannes Sixt wrote:
> Michael Pyne schrieb:
> > It took a lot of thinking (and a bit of Perl) to confirm it, but your
> > patch does indeed add ~,!,[,] to the list of characters to check.
> > 
> > However is there an "official" list of characters required to be escaped
> > somewhere so we can confirm these aren't the only 4 missing ones?
> I wonder why a list of characters is needed at all: Just do the quoting
> unconditionally.

Well, that would make the cd command (which appears in dolphin's
embedded terminal for instance) unreadable.

David Faure, faure at,
Sponsored by Nokia to work on KDE, incl. Konqueror (

More information about the kde-core-devel mailing list