Review Request: Unquoted/unescaped directory name passed to "cd" command in dolphin embedded terminal

Johannes Sixt j.sixt at viscovery.net
Mon Jan 25 08:24:22 GMT 2010


Michael Pyne schrieb:
> It took a lot of thinking (and a bit of Perl) to confirm it, but your patch does indeed add ~,!,[,] to the list of characters to check.
> 
> However is there an "official" list of characters required to be escaped somewhere so we can confirm these aren't the only 4 missing ones?

I wonder why a list of characters is needed at all: Just do the quoting
unconditionally.

-- Hannes





More information about the kde-core-devel mailing list