Review Request: Unquoted/unescaped directory name passed to "cd" command in dolphin embedded terminal

Oswald Buddenhagen ossi at kde.org
Mon Jan 25 10:55:00 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2703/#review3863
-----------------------------------------------------------


argh, why doesn't the title mention the class which it changes, or even that it changes kdelibs at all?
when you commit it, use a generic message like "quote the tilde, square brackets and the exclamation mark". you may add more info in a second paragraph if you wish to.

the exclamation mark is special only to interactive shells. the function was never meant to be used in that context, so i didn't consider it ... but i guess it won't hurt.
the tilde is special only at the beginning of a token. but then, the same applies to the hashmark and i didn't bother to handle it specially, either. so i guess it is ok.
considering that the asterisk and question mark wildcards are quoted, not quoting the brackets is probably just a simple omission, indeed.

special handling of brackets needs to be applied to the isMeta() function further up as well. its user (splitArgs()) already handles the tilde separately, and the bang is not applicable to it, so these bits should not be added.


- Oswald


On 2010-01-23 21:03:49, Nicolas L├ęcureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2703/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 21:03:49)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add !~[] as special letters to be escaped, this fix the use of the embeded terminal
> 
> 
> This addresses bug 220092.
>     https://bugs.kde.org/show_bug.cgi?id=220092
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/util/kshell_unix.cpp 1077455 
> 
> Diff: http://reviewboard.kde.org/r/2703/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>





More information about the kde-core-devel mailing list