Review Request: Make the Ctrl+L shortcut toggle between editable modes of KUrlNavigator in KFileWidget

[Harsh J]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2729/
-----------------------------------------------------------

(Updated 2010-01-25 20:02:55.123076)


Review request for kdelibs and Shaun Reich.


Changes
-------

Small description title update.


Summary (updated)
-------

This patch proposes to make the Ctrl+L shortcut of the breadcrumb/edit bar toggle between the editable modes. Dolphin toggles its bar in the same way (using one single shortcut) so why not this - as sreich pointed out on #kde-devel :)

Ctrl+Return would still make it switch back to non-editable mode, no edits made with that behaviour.


Diffs
-----

  /trunk/KDE/kdelibs/kfile/kfilewidget.cpp 1079650 

Diff: http://reviewboard.kde.org/r/2729/diff


Testing
-------

Hitting Ctrl+L (After a logout/login) makes it toggle between editable modes, just like the behavior is in Dolphin. Selection of the text upon edit mode remains unchanged, like before.


Thanks,

Harsh