Review Request: Make the Ctrl+L shortcut toggle between editable modes of KUrlNavigator in KFileWidget

[Shaun Reich]

> On 2010-01-25 19:29:25, Andreas Pakulat wrote:
> > No way, at least not as default shortcut on an widely-used widget - IMHO. The choice wether that shortcut should be set on the widget belongs to the application hosting it, not the widget itself. So provide an API that allows setting a shortcut for toggling the editable modes, but please don't set a shortcut as default.
> 
> Harsh J wrote:
>     The short-cut is definitely configurable - all I'm changing is the part where a successive activation of this method would toggle between editable and non-editable modes.
>     
>     Ctrl+L is used by KFileWidget (its set into its code), sorry for not stating that earlier - I think the actual description was a bit ambiguous.
>     
>     Perhaps this change is in the wrong area? (Private method...)

Yes, it is in it's current state (imo), a bug. The shortcut is already being used to move from breadcrumb mode->edit mode, but not visa versa.


- Shaun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2729/#review3877
-----------------------------------------------------------


On 2010-01-25 20:02:55, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2729/
> -----------------------------------------------------------
> 
> (Updated 2010-01-25 20:02:55)
> 
> 
> Review request for kdelibs and Shaun Reich.
> 
> 
> Summary
> -------
> 
> This patch proposes to make the Ctrl+L shortcut of the breadcrumb/edit bar toggle between the editable modes. Dolphin toggles its bar in the same way (using one single shortcut) so why not this - as sreich pointed out on #kde-devel :)
> 
> Ctrl+Return would still make it switch back to non-editable mode, no edits made with that behaviour.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfilewidget.cpp 1079650 
> 
> Diff: http://reviewboard.kde.org/r/2729/diff
> 
> 
> Testing
> -------
> 
> Hitting Ctrl+L (After a logout/login) makes it toggle between editable modes, just like the behavior is in Dolphin. Selection of the text upon edit mode remains unchanged, like before.
> 
> 
> Thanks,
> 
> Harsh
> 
>