Review Request: Unquoted/unescaped directory name passed to "cd" command in dolphin embedded terminal

Michael Pyne mpyne at kde.org
Sat Jan 23 22:20:30 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2703/#review3823
-----------------------------------------------------------


It took a lot of thinking (and a bit of Perl) to confirm it, but your patch does indeed add ~,!,[,] to the list of characters to check.

However is there an "official" list of characters required to be escaped somewhere so we can confirm these aren't the only 4 missing ones?

- Michael


On 2010-01-23 21:03:49, Nicolas L├ęcureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2703/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 21:03:49)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add !~[] as special letters to be escaped, this fix the use of the embeded terminal
> 
> 
> This addresses bug 220092.
>     https://bugs.kde.org/show_bug.cgi?id=220092
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/util/kshell_unix.cpp 1077455 
> 
> Diff: http://reviewboard.kde.org/r/2703/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>





More information about the kde-core-devel mailing list