Review Request: make Solid::Control::PowerManager::brightness check if a control for the screen is available

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2479/#review3566
-----------------------------------------------------------

Ship it!


Good catch. Please commit.

- Kevin


On 2010-01-02 19:20:12, Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2479/
> -----------------------------------------------------------
> 
> (Updated 2010-01-02 19:20:12)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The brightness functions in solid only check if controls.size() == 0 but not for the right type of control to be in the list. This leads to crashes in the battery plasma applet on my system (some recent KDE 4.4 change triggers it).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp 1069076 
> 
> Diff: http://reviewboard.kde.org/r/2479/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik
> 
>