Review Request: make Solid::Control::PowerManager::brightness check if a control for the screen is available

Frederik Gladhorn gladhorn at kde.org
Sat Jan 2 19:20:12 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2479/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The brightness functions in solid only check if controls.size() == 0 but not for the right type of control to be in the list. This leads to crashes in the battery plasma applet on my system (some recent KDE 4.4 change triggers it).


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp 1069076 

Diff: http://reviewboard.kde.org/r/2479/diff


Testing
-------


Thanks,

Frederik





More information about the kde-core-devel mailing list