[Kde-games-devel] moved Kajongg from playground to kdereview
tcanabrava at kde.org
Mon Feb 22 23:21:19 GMT 2010
it probably use KGameCanvas.
why there's a KGameCanvas when there's QGraphicsView around?
I do understand that it was because in the pre kde4 days, QGV was buggy,
but now it isn't that ( and plasma relies heavly on it ).
2010/2/22 Ingo Klöcker <kloecker at kde.org>:
> On Sunday 21 February 2010, Wolfgang Rohdewald wrote:
>> On Sunday 21 February 2010, Ingo Klöcker wrote:
>> > > This would fix one bug in libkmahjongg, though: If in
>> > > KMahjongg you click on the shadow of a tile, that tile
>> > > is selected even if there is another tile under that
>> > > shadow. The shadowed tile should be selected, not the
>> > > shadowing tile. This works correctly with my code
>> > > although I don't actually need this.
>> > This example clearly demonstrates why code duplication is bad.
>> > KMahjongg does not benefit from your bug fix because you
>> > fixed the bug only in the duplicated code.
>> While you are theoretically of course absolutely right,
>> there was no alternative for me personally.
> Yes, it's mostly theory. Theory clearly has its limit if different
> languages come into play.
> And as, apparently, libkmahjongg doesn't even use QGV (which is very
> surprising; what does it use instead?; widgets?) I can understand why
> you chose to rewrite some of its code.
More information about the kde-core-devel