[Kde-games-devel] moved Kajongg from playground to kdereview
kloecker at kde.org
Mon Feb 22 20:24:46 GMT 2010
On Sunday 21 February 2010, Wolfgang Rohdewald wrote:
> On Sunday 21 February 2010, Ingo Klöcker wrote:
> > > This would fix one bug in libkmahjongg, though: If in
> > > KMahjongg you click on the shadow of a tile, that tile
> > > is selected even if there is another tile under that
> > > shadow. The shadowed tile should be selected, not the
> > > shadowing tile. This works correctly with my code
> > > although I don't actually need this.
> > This example clearly demonstrates why code duplication is bad.
> > KMahjongg does not benefit from your bug fix because you
> > fixed the bug only in the duplicated code.
> While you are theoretically of course absolutely right,
> there was no alternative for me personally.
Yes, it's mostly theory. Theory clearly has its limit if different
languages come into play.
And as, apparently, libkmahjongg doesn't even use QGV (which is very
surprising; what does it use instead?; widgets?) I can understand why
you chose to rewrite some of its code.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel