Review Request: Check the list to randomize is not empty in KRandomSequence
Jaime Torres
jtamate at gmail.com
Tue Feb 16 11:39:06 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2915/#review4176
-----------------------------------------------------------
Ship it!
This patch is simple enough, and safe, for me to say Ship It my first time.
- Jaime
On 2010-02-15 20:43:39, Anne-Marie Mahfouf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2915/
> -----------------------------------------------------------
>
> (Updated 2010-02-15 20:43:39)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Checking the list to randomize is not empty fixes several crashes I get using KRandomSequence in various places.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kdecore/util/krandomsequence.h 1090448
>
> Diff: http://reviewboard.kde.org/r/2915/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne-Marie
>
>
More information about the kde-core-devel
mailing list