Review Request: Check the list to randomize is not empty in KRandomSequence

Anne-Marie Mahfouf annma at kde.org
Mon Feb 15 20:43:39 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2915/
-----------------------------------------------------------

(Updated 2010-02-15 20:43:39.695677)


Review request for kdelibs.


Changes
-------

Thanks Jaime (and people on IRC), indeed I got it wrong. Here is the updated proposed patch.


Summary
-------

Checking the list to randomize is not empty fixes several crashes I get using KRandomSequence in various places.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdecore/util/krandomsequence.h 1090448 

Diff: http://reviewboard.kde.org/r/2915/diff


Testing
-------


Thanks,

Anne-Marie





More information about the kde-core-devel mailing list