Review Request: Add an associated widget to the action collection in KDirSelectDialog and KFileWidget

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2838/#review4109
-----------------------------------------------------------

Ship it!


Looks good (assuming none of these shorcuts conflict with existing shortcuts in one of the dialog's widget)

- David


On 2010-02-08 23:56:07, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2838/
> -----------------------------------------------------------
> 
> (Updated 2010-02-08 23:56:07)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> None of the shortcuts defined in KDirSelectDialog and KFileWidget (such as Show hidden files, Create New Folder etc) were working, although triggering the actions in another way did work as expected.
> 
> The shortcuts work fine if the dialog itself is added as an associated widget of the action collection.
> 
> I don't know how long it's been broken (or if it has ever worked as expected ;). Is a unit test required?
> 
> 
> This addresses bug 225744.
>     https://bugs.kde.org/show_bug.cgi?id=225744
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfilewidget.cpp 1083310 
>   /trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp 1083310 
> 
> Diff: http://reviewboard.kde.org/r/2838/diff
> 
> 
> Testing
> -------
> 
> Bug 225744 couldn't be reproduced after the patch.
> 
> 
> Thanks,
> 
> Raphael
> 
>