Review Request: Add an associated widget to the action collection in KDirSelectDialog and KFileWidget

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2838/
-----------------------------------------------------------

(Updated 2010-02-08 23:56:07.910687)


Review request for kdelibs.


Changes
-------

This new patch also adds an associated widget to KFileWidget, thus making shortcuts work in KFileDialog as well.


Summary (updated)
-------

None of the shortcuts defined in KDirSelectDialog and KFileWidget (such as Show hidden files, Create New Folder etc) were working, although triggering the actions in another way did work as expected.

The shortcuts work fine if the dialog itself is added as an associated widget of the action collection.

I don't know how long it's been broken (or if it has ever worked as expected ;). Is a unit test required?


This addresses bug 225744.
    https://bugs.kde.org/show_bug.cgi?id=225744


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kfilewidget.cpp 1083310 
  /trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp 1083310 

Diff: http://reviewboard.kde.org/r/2838/diff


Testing
-------

Bug 225744 couldn't be reproduced after the patch.


Thanks,

Raphael