Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

[George Metaxas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6204/
-----------------------------------------------------------

(Updated 2010-12-26 21:26:23.032289)


Review request for kdelibs.


Changes
-------

Addressed all of Raphael's comments. I did not make an extra enableMoveButtons slot. I changed it back to the way it was originally, and just acquired the QItemSelection I needed inside the slot. I also added a comment to suggest that the enableMoveButtons definition should be changed to reflect the new behaviour.


Summary
-------

In order to satisfy Bug 219574, the KEditListBox and KEditListWidget widgets need to have multiple item selection support. This patch adds the familiar type of multiple item selection (select items by pressing CTRL + Left Click, and select consecutive regions with SHIFT + Left click) in both of these widgets. The patch also allows the removal of the multiply selected items from the embedded listview, as well as moving them up or down (while maintaining the same selection pattern). This patch will be required in order to completely solve Bug 219574.


This addresses bug 219574.
    https://bugs.kde.org/show_bug.cgi?id=219574


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h 1209267 
  /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp 1209267 
  /trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h 1209267 
  /trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.cpp 1209267 

Diff: http://svn.reviewboard.kde.org/r/6204/diff


Testing
-------

Tested the multiple item selection, moving and removing multiply selected items.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101226/45ace1aa/attachment.htm>