Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6204/#review9419
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h
<http://svn.reviewboard.kde.org/r/6204/#comment10430>

    I don't think you're allowed to change this slot's signature, as this is a binary-incommpatible change. Add a new slot instead.



/trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp
<http://svn.reviewboard.kde.org/r/6204/#comment10431>

    According to kdelibs' coding style, you should #include both module and class name for Qt includes.



/trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp
<http://svn.reviewboard.kde.org/r/6204/#comment10432>

    Unnecessary change.



/trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h
<http://svn.reviewboard.kde.org/r/6204/#comment10433>

    Missing @since 4.7, and the method can be const.



/trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h
<http://svn.reviewboard.kde.org/r/6204/#comment10434>

    Ditto.



/trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h
<http://svn.reviewboard.kde.org/r/6204/#comment10435>

    Same thing about keeping binary compatibility.


- Raphael


On 2010-12-25 15:13:50, George  Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6204/
> -----------------------------------------------------------
> 
> (Updated 2010-12-25 15:13:50)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> In order to satisfy Bug 219574, the KEditListBox and KEditListWidget widgets need to have multiple item selection support. This patch adds the familiar type of multiple item selection (select items by pressing CTRL + Left Click, and select consecutive regions with SHIFT + Left click) in both of these widgets. The patch also allows the removal of the multiply selected items from the embedded listview, as well as moving them up or down (while maintaining the same selection pattern). This patch will be required in order to completely solve Bug 219574.
> 
> 
> This addresses bug 219574.
>     https://bugs.kde.org/show_bug.cgi?id=219574
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h 1209179 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp 1209179 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h 1209179 
>   /trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.cpp 1209179 
> 
> Diff: http://svn.reviewboard.kde.org/r/6204/diff
> 
> 
> Testing
> -------
> 
> Tested the multiple item selection, moving and removing multiply selected items.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101226/fe034402/attachment.htm>