<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6204/">http://svn.reviewboard.kde.org/r/6204/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By George Metaxas.</div>
<p style="color: grey;"><i>Updated 2010-12-26 21:26:23.032289</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed all of Raphael's comments. I did not make an extra enableMoveButtons slot. I changed it back to the way it was originally, and just acquired the QItemSelection I needed inside the slot. I also added a comment to suggest that the enableMoveButtons definition should be changed to reflect the new behaviour.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to satisfy Bug 219574, the KEditListBox and KEditListWidget widgets need to have multiple item selection support. This patch adds the familiar type of multiple item selection (select items by pressing CTRL + Left Click, and select consecutive regions with SHIFT + Left click) in both of these widgets. The patch also allows the removal of the multiply selected items from the embedded listview, as well as moving them up or down (while maintaining the same selection pattern). This patch will be required in order to completely solve Bug 219574.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the multiple item selection, moving and removing multiply selected items.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=219574">219574</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.h <span style="color: grey">(1209267)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp <span style="color: grey">(1209267)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.h <span style="color: grey">(1209267)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/keditlistwidget.cpp <span style="color: grey">(1209267)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6204/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>