Review Request: Fix for naming inconsistency with name suggestion in dolphin

[Mark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5160/
-----------------------------------------------------------

Review request for Dolphin, kdelibs and David Faure.


Summary
-------

I started with this fix because of bug 237022 but it's not fixing that bug. That bug reporter wants a new naming suggestion to look like:
"New_Folder_1"

The current behavior is:
"New Folder_1" (a mixture between spaces and underscore)

And this patch makes it look like:
"New Folder 1" (only spaces)

I however am in favor of using a translatable string so the spacer can be changed by those that translate.. That fix would only mean changing:
const QChar spacer(' ');

to
QString spacer = i18nc("New name suggestion spacer", " ");

The in becomes possible to get suggestions like:
"New_Folder_1" (assuming the "New Folder" name is also changed in the translation files)
It kinda depends on Peter and dfaure which option (translatable or not) is picked.

So, to clarify it. This fix it _not_ fixing bug 237022 but is making it consistent. That bug report (when this patch without translatable line gets accepted) should be closed as "WONTFIX" since it's a special user preference...


This addresses bug 237022.
    https://bugs.kde.org/show_bug.cgi?id=237022


Diffs
-----

  /tags/KDE/4.5.0/kdelibs/kio/kio/renamedialog.cpp 1168303 

Diff: http://reviewboard.kde.org/r/5160/diff


Testing
-------

Made the patch, compiled it and tested it by making new files/folders. It seems to work just fine.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100826/1c404886/attachment.htm>