Review Request: Use Qt cout and cerr

Jaime Torres jtamate at gmail.com
Thu Aug 26 18:52:43 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5158/
-----------------------------------------------------------

(Updated 2010-08-26 17:52:42.690593)


Review request for kdelibs.


Changes
-------

I used the anonymous namespace. But remember that kconfig_compiler.cpp generates an executable, it is not a shared library.
There are more global variables, but they will be classified (introduced in a class) in a later patch.
Also removed (and checked) the qPrintable macro.


Summary
-------

Use Qt cout and cerr. Qt already has in cout the methods for a lot of Qt data types.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1168408 

Diff: http://reviewboard.kde.org/r/5158/diff


Testing
-------

Works in linux and cygwin.


Thanks,

Jaime

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100826/71a53396/attachment.htm>


More information about the kde-core-devel mailing list