Review Request: Allow formatting times without the hours-part, adding hours*60 to the minutes-part

[Tom Albers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5132/#review7235
-----------------------------------------------------------


Seems to work fine. I've adapted Spokify and tested the patch. It seems to work. A leading 0 for time < 10 minutes, can be discussed to let it all align, but i dont think it is needed, as minutes could be more than 99 as well, which would break the layout again. I do not feel qualified to sign off on a kdelibs patch though...

What remains is to thanks you for the quick patch!

- Tom


On 2010-08-24 11:12:20, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5132/
> -----------------------------------------------------------
> 
> (Updated 2010-08-24 11:12:20)
> 
> 
> Review request for kdelibs and Tom Albers.
> 
> 
> Summary
> -------
> 
> Add a new TimeFoldHours flag to the KLocale::TimeFormatOptions which allows the readLocaleTime/formatLocaleTime to remove the hours part of the time and add the hours*60 to the minutes part. This is useful when reading/formating the duration of a song, eg. 70:00 instead of 01:10:00. Folding hours is only supported for durations.
> 
> @toma: CCed you as you requested this feature. Feel free to review if you feel like it though :-)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/localization/klocale.h 1167163 
>   /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1167163 
>   /trunk/KDE/kdelibs/kdecore/tests/klocaletimeformattest.cpp 1167163 
> 
> Diff: http://reviewboard.kde.org/r/5132/diff
> 
> 
> Testing
> -------
> 
> Added new testcases checking the new functionality to unit-tests. It might need 2 more testcases which I'll look into adding soon.
> 
> 
> Thanks,
> 
> Michael
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100826/fa8e966d/attachment.htm>