Review Request: Allow formatting times without the hours-part, adding hours*60 to the minutes-part

Michael Leupold lemma at confuego.org
Tue Aug 24 12:12:20 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5132/
-----------------------------------------------------------

Review request for kdelibs and Tom Albers.


Summary
-------

Add a new TimeFoldHours flag to the KLocale::TimeFormatOptions which allows the readLocaleTime/formatLocaleTime to remove the hours part of the time and add the hours*60 to the minutes part. This is useful when reading/formating the duration of a song, eg. 70:00 instead of 01:10:00. Folding hours is only supported for durations.

@toma: CCed you as you requested this feature. Feel free to review if you feel like it though :-)


Diffs
-----

  /trunk/KDE/kdelibs/kdecore/localization/klocale.h 1167163 
  /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1167163 
  /trunk/KDE/kdelibs/kdecore/tests/klocaletimeformattest.cpp 1167163 

Diff: http://reviewboard.kde.org/r/5132/diff


Testing
-------

Added new testcases checking the new functionality to unit-tests. It might need 2 more testcases which I'll look into adding soon.


Thanks,

Michael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100824/8d89807d/attachment.htm>


More information about the kde-core-devel mailing list