Review Request: Update thumbnail support for Microsoft Windows executables and images

Pali Rohár pali.rohar at
Thu Aug 26 12:41:35 BST 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


This patch update (and clean) code of generating Windows ico/cur/exe/dll/... thumbnails. It fix generating thumbnails for exe files which has a lot of icons/cursors, group icons/cursors with or without name or only index.

It remove MimeType application/x-win-lnk from windowsexethumbnail.desktop file, because for Windows Link files are needed parsing lnk files. This thumbnail generator has never support lnk files, patch for lnk files is on .

It also remove using external app icotool (part of icoutils; needed for converting ico to png) and instead this use native Qt functions (class QImageReader). But this has a bug in Qt. Qt cannot read image from .cur files.
Qt bug is reported here: where is my patch which fix reading image from windows cursor .cur files.

This patch still using external app wrestool (part of icoutils; needed for extracting icons/cursors from exe/dll files), so package icoutils is still needed in user system.


  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h 1159791 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp 1159791 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.h 1159791 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.cpp 1159791 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexethumbnail.desktop 1159791 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.h 1159791 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.cpp 1159791 



When I'm using Qt compiled with patch from generating works fine without problems.
When I'm using Qt compiled without patch, generating thumbnails for Windows cursor files (or exe/dll file with only cursor image) do not work. Other (ico files and exe/dll files with ico) images works fine.

If app wrestool is not in user system (in PATH), generating thumbnails for exe/dll files does not work. But work generating for ico/cur files (because code for converting ico/cur is in QtGui).



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list