<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5156/">http://reviewboard.kde.org/r/5156/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Pali Rohár.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch update (and clean) code of generating Windows ico/cur/exe/dll/... thumbnails. It fix generating thumbnails for exe files which has a lot of icons/cursors, group icons/cursors with or without name or only index.
It remove MimeType application/x-win-lnk from windowsexethumbnail.desktop file, because for Windows Link files are needed parsing lnk files. This thumbnail generator has never support lnk files, patch for lnk files is on http://reviewboard.kde.org/r/4817/ .
It also remove using external app icotool (part of icoutils; needed for converting ico to png) and instead this use native Qt functions (class QImageReader). But this has a bug in Qt. Qt cannot read image from .cur files.
Qt bug is reported here: http://bugreports.qt.nokia.com/browse/QTBUG-12684 where is my patch which fix reading image from windows cursor .cur files.
This patch still using external app wrestool (part of icoutils; needed for extracting icons/cursors from exe/dll files), so package icoutils is still needed in user system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I'm using Qt compiled with patch from http://bugreports.qt.nokia.com/secure/attachment/16337/qt-ico-cur.patch generating works fine without problems.
When I'm using Qt compiled without patch, generating thumbnails for Windows cursor files (or exe/dll file with only cursor image) do not work. Other (ico files and exe/dll files with ico) images works fine.
If app wrestool is not in user system (in PATH), generating thumbnails for exe/dll files does not work. But work generating for ico/cur files (because code for converting ico/cur is in QtGui).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h <span style="color: grey">(1159791)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp <span style="color: grey">(1159791)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.h <span style="color: grey">(1159791)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.cpp <span style="color: grey">(1159791)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexethumbnail.desktop <span style="color: grey">(1159791)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.h <span style="color: grey">(1159791)</span></li>
<li>/trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.cpp <span style="color: grey">(1159791)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5156/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>