Review Request: Make KNewFileMenu working asynchronously (don't block plasma shell from folderview)

[Björn Ruberg]

An Dienstag, 10. August 2010 20:33:31 schrieb Aaron Seigo:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4964/#review6976
> -----------------------------------------------------------
> 
> 
> the idea is a good one; there are issues with the patch as it stands,
> however, related to public API and binary compatibility. they will need to
> be addressed before this can go in.
> 
> 
> /trunk/KDE/kdelibs/kfile/knewfilemenu.h
> <http://reviewboard.kde.org/r/4964/#comment7006>
> 
>     should be const (and next to setModal in the header for claright?)
> 
> 
> 
> /trunk/KDE/kdelibs/kfile/knewfilemenu.h
> <http://reviewboard.kde.org/r/4964/#comment7008>
> 
>     all of these slots should not be in the public class.
> 
>     instead, they should all be in the private class (KNewFileMenuPrivate)
> and Q_PRIVATE_SLOT should be used...
> 
>     from this same file:
> 
>     Q_PRIVATE_SLOT(d, void _k_slotFillTemplates())
> 
>     these new slots should also (for consistency) use that same naming
> pattern: _k_slot<WhatItDoes>()
> 
> 
> 
> /trunk/KDE/kdelibs/kfile/knewfilemenu.h
> <http://reviewboard.kde.org/r/4964/#comment7007>
> 
>     lower case the first letter in metods (same for ReadFileOrDirCallback
> bellow)
> 
> 
> 
> /trunk/KDE/kdelibs/kfile/knewfilemenu.h
> <http://reviewboard.kde.org/r/4964/#comment7009>
> 
>     new class members must go into the private class to preserve binary
> compatibility.
> 
> 
> - Aaron

I tried to address all these issues in my new patch. Just need a "go" to sumit 
it.