Review Request: Make KNewFileMenu working asynchronously (don't block plasma shell from folderview)

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4964/#review6976
-----------------------------------------------------------


the idea is a good one; there are issues with the patch as it stands, however, related to public API and binary compatibility. they will need to be addressed before this can go in.


/trunk/KDE/kdelibs/kfile/knewfilemenu.h
<http://reviewboard.kde.org/r/4964/#comment7006>

    should be const (and next to setModal in the header for claright?)



/trunk/KDE/kdelibs/kfile/knewfilemenu.h
<http://reviewboard.kde.org/r/4964/#comment7008>

    all of these slots should not be in the public class.
    
    instead, they should all be in the private class (KNewFileMenuPrivate) and Q_PRIVATE_SLOT should be used...
    
    from this same file:
    
    Q_PRIVATE_SLOT(d, void _k_slotFillTemplates())
    
    these new slots should also (for consistency) use that same naming pattern: _k_slot<WhatItDoes>()



/trunk/KDE/kdelibs/kfile/knewfilemenu.h
<http://reviewboard.kde.org/r/4964/#comment7007>

    lower case the first letter in metods (same for ReadFileOrDirCallback bellow)



/trunk/KDE/kdelibs/kfile/knewfilemenu.h
<http://reviewboard.kde.org/r/4964/#comment7009>

    new class members must go into the private class to preserve binary compatibility.


- Aaron


On 2010-08-10 11:39:11, Björn Ruberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4964/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 11:39:11)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> This patch makes the dialogs created by KNewFileMenu asynchronously. It's now possible to get non-modal dialogs with it. This is a feature that is needed for plasma folderview, because modal dialogs block the whole plasma shell. So this is the main part of a fix for bug #167243.
> By the default the dialogs will stay modal, so there should be no change for other applications. Folderview just needs to call setModal(false) on the KNewFileMenu (have a patch for that, too). But as this touches much code (and orders methods alphabetically ;) ) you can never be sure that there is no change.
> 
> Please have closer look whether the dialogs are deleted probably. I'm not doing it directly but relying on Qt::WA_DeleteOnClose. 
> 
> 
> This addresses bug #167243.
>     https://bugs.kde.org/show_bug.cgi?id=#167243
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/knewfilemenu.h 1161027 
>   /trunk/KDE/kdelibs/kfile/knewfilemenu.cpp 1161027 
> 
> Diff: http://reviewboard.kde.org/r/4964/diff
> 
> 
> Testing
> -------
> 
> There are five different code pathes that I have worked on:
> - create directory
> - create normal file
> - create symlink
> - create URL 
> - create .desktop file 
> 
> I tested all of them and they work for me.
> 
> 
> Thanks,
> 
> Björn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100810/6014db48/attachment.htm>