Review Request: Make KNewFileMenu working asynchronously (don't block plasma shell from folderview)

Björn Ruberg bjoern at
Fri Aug 13 18:57:10 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-08-13 17:57:09.865503)

Review request for kdelibs and David Faure.


Hope I got everything right this time. Please review again. 


This patch makes the dialogs created by KNewFileMenu asynchronously. It's now possible to get non-modal dialogs with it. This is a feature that is needed for plasma folderview, because modal dialogs block the whole plasma shell. So this is the main part of a fix for bug #167243.
By the default the dialogs will stay modal, so there should be no change for other applications. Folderview just needs to call setModal(false) on the KNewFileMenu (have a patch for that, too). But as this touches much code (and orders methods alphabetically ;) ) you can never be sure that there is no change.

Please have closer look whether the dialogs are deleted probably. I'm not doing it directly but relying on Qt::WA_DeleteOnClose. 

This addresses bug #167243.

Diffs (updated)

  /trunk/KDE/kdelibs/kfile/knewfilemenu.h 1161027 
  /trunk/KDE/kdelibs/kfile/knewfilemenu.cpp 1161027 



There are five different code pathes that I have worked on:
- create directory
- create normal file
- create symlink
- create URL 
- create .desktop file 

I tested all of them and they work for me.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list