Review Request: Add an overload to blocking*Query, returning the results

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3815/#review5252
-----------------------------------------------------------



/trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h
<http://reviewboard.kde.org/r/3815/#comment4743>

    Nitpicking: \since 4.5



/trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h
<http://reviewboard.kde.org/r/3815/#comment4746>

    how about calling it syncQuery and make the ok parameter optional?



/trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h
<http://reviewboard.kde.org/r/3815/#comment4744>

    \since 4.5



/trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h
<http://reviewboard.kde.org/r/3815/#comment4745>

    \since 4.5


- Sebastian


On 2010-04-27 07:43:21, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3815/
> -----------------------------------------------------------
> 
> (Updated 2010-04-27 07:43:21)
> 
> 
> Review request for kdelibs and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> This patch adds an overload to each blocking query method which returns the list of the results instead of a boolean. The query result can still be monitored through bool *ok, in a similar fashion to what Qt does (for example, QString::toInt).
> 
> I also wrote a small test case for it, but then realized that queryservice can not be told to use a different model from the main one. If there's a way to do that, I'd happily add the test case as well :)
> 
> P.S.: Should the old blocking query functions be marked as deprecated?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h 1119285 
>   /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp 1119285 
>   /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3815/diff
> 
> 
> Testing
> -------
> 
> Works(tm)
> 
> 
> Thanks,
> 
> Dario
> 
>