Review Request: Add an overload to blocking*Query, returning the results

Dario Freddi drf54321 at
Tue Apr 27 08:43:21 BST 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and Sebastian Trueg.


This patch adds an overload to each blocking query method which returns the list of the results instead of a boolean. The query result can still be monitored through bool *ok, in a similar fashion to what Qt does (for example, QString::toInt).

I also wrote a small test case for it, but then realized that queryservice can not be told to use a different model from the main one. If there's a way to do that, I'd happily add the test case as well :)

P.S.: Should the old blocking query functions be marked as deprecated?


  /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h 1119285 
  /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp 1119285 
  /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient_p.h PRE-CREATION 






More information about the kde-core-devel mailing list