Review Request: Add new methods sync*Query, returning the results

Dario Freddi drf54321 at
Tue Apr 27 10:48:50 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-04-27 09:48:50.823163)

Review request for kdelibs and Sebastian Trueg.


 * Added \since 4.5
 * New method names instead of overloads, which let me specify 0 as default parameter for the various *ok
 * Moved *ok as the last argument

Summary (updated)

This patch adds a new method for each corresponding blocking query method which returns the list of the results instead of a boolean. The query result can still be monitored through bool *ok, in a similar fashion to what Qt does (for example, QString::toInt).

I also wrote a small test case for it, but then realized that queryservice can not be told to use a different model from the main one. If there's a way to do that, I'd happily add the test case as well :)

Diffs (updated)

  /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h 1119285 
  /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp 1119285 
  /trunk/KDE/kdelibs/nepomuk/query/queryserviceclient_p.h PRE-CREATION 






More information about the kde-core-devel mailing list