Review Request: Fix loss of formatting when removing a link from a KRichTextEdit derived editor.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3609/#review5071
-----------------------------------------------------------


Is it possible to add your test case to the unit tests or add some test for this?


/trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp
<http://reviewboard.kde.org/r/3609/#comment4550>

    I don't think so many comments like this in the following lines are necessary in this case.



/trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp
<http://reviewboard.kde.org/r/3609/#comment4552>

    Maybe const QTextCharFormat originalFormat = format; ?



/trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp
<http://reviewboard.kde.org/r/3609/#comment4551>

    Would be nice to update it to the new bug number (QTBUG-1814).


- Raphael


On 2010-04-15 12:34:06, Jason Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3609/
> -----------------------------------------------------------
> 
> (Updated 2010-04-15 12:34:06)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KRichTextEdit derived editors would remove all formatting when a link was removed from the text, not just the link related formatting. This patch allows the text to retain its non-link related formatting, and also cleans up the overall KRichTextEdit::updateLink method to make the logic a little simpler.
> 
> 
> This addresses bug 234439.
>     https://bugs.kde.org/show_bug.cgi?id=234439
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1115143 
> 
> Diff: http://reviewboard.kde.org/r/3609/diff
> 
> 
> Testing
> -------
> 
> Made a test case with a KRichTextEdit component to ensure the behavior was as expected.
> 
> 
> Thanks,
> 
> Jason
> 
>