Review Request: Fix loss of formatting when removing a link from a KRichTextEdit derived editor.

Jason Jackson jaxhoo at gmail.com
Thu Apr 15 13:34:06 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3609/
-----------------------------------------------------------

(Updated 2010-04-15 12:34:06.237503)


Review request for kdelibs.


Changes
-------

Removed kDebug() lines.


Summary
-------

KRichTextEdit derived editors would remove all formatting when a link was removed from the text, not just the link related formatting. This patch allows the text to retain its non-link related formatting, and also cleans up the overall KRichTextEdit::updateLink method to make the logic a little simpler.


This addresses bug 234439.
    https://bugs.kde.org/show_bug.cgi?id=234439


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1115143 

Diff: http://reviewboard.kde.org/r/3609/diff


Testing
-------

Made a test case with a KRichTextEdit component to ensure the behavior was as expected.


Thanks,

Jason





More information about the kde-core-devel mailing list