Review Request: Fix loss of formatting when removing a link from a KRichTextEdit derived editor.

[Jason Jackson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3609/
-----------------------------------------------------------

(Updated 2010-04-22 10:32:10.396933)


Review request for kdelibs.


Changes
-------

Completed the changes requested by Raphael Kubo da Costa, including the addition of two test cases. One validates the format after creating a link, the other validates the formatting after removing the link.


Summary
-------

KRichTextEdit derived editors would remove all formatting when a link was removed from the text, not just the link related formatting. This patch allows the text to retain its non-link related formatting, and also cleans up the overall KRichTextEdit::updateLink method to make the logic a little simpler.


This addresses bug 234439.
    https://bugs.kde.org/show_bug.cgi?id=234439


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp 1116838 
  /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.h 1116838 
  /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1116838 

Diff: http://reviewboard.kde.org/r/3609/diff


Testing
-------

Made a test case with a KRichTextEdit component to ensure the behavior was as expected.


Thanks,

Jason