Review Request: Provide different maximum file sizes for PreviewJob, dependent on whether a file is local or remote

Peter Penz peter.penz at
Sun Apr 11 11:35:12 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-04-11 10:35:11.729700)

Review request for kdelibs and David Faure.


Currently PreviewJob uses the same maximum file size for local or remote files. The attached patch improves this, so that it is possible for the user to specify different maximum sizes for local and remote files. The default size for remote files has been set to 0.

To be discussed: For KDE 4.1 the method
  static KIO::filesize_t PreviewJob::maximumFileSize();
has been introduced. Corresponding to it is not used at all and I'm wondering, whether it makes sense to offer this method at all. IMO we should either:
a) Introduce corresponding setter methods too
b) Just declare this method as deprecated (and remove it in KDE 5)

Beside the maximumFileSize() detail: Are there any objections to commit the patch?

This addresses bug 211007.


  trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1111289 





More information about the kde-core-devel mailing list